Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiline comments for examples in csharp generator #19079

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

ReallyLiri
Copy link
Contributor

@ReallyLiri ReallyLiri commented Jul 4, 2024

When an example is multiline, the generated code contains uncommented free text.
For example reproducible using csharp generator on this openapi spec: https://github.com/DataDog/datadog-api-client-go/blob/master/.generator/schemas/v2/openapi.yaml

@wing328
Copy link
Member

wing328 commented Jul 7, 2024

cc @mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

cc @devhl-labs (generichost)

@devhl-labs
Copy link
Contributor

Partial fix for #19626

@wing328 wing328 merged commit b4edca5 into OpenAPITools:master Sep 22, 2024
51 checks passed
@wing328 wing328 added this to the 7.9.0 milestone Sep 22, 2024
nicolas-vivot pushed a commit to nicolas-vivot/openapi-generator that referenced this pull request Sep 23, 2024
wing328 added a commit that referenced this pull request Sep 25, 2024
* [Swift6] create Swift6 generator

* [Swift6] create Swift6 generator

* Update vapor integration

* Update bitrise stack to Xcode 16

* [Swift6] tryped throws

* [Swift6] tryped throws

* [Swift6] combine deferred and api static method

* [Swift6] update readme

* [Swift6] fix some errors

* [Swift6] fix some errors

* [Swift6] fix some errors

* [Swift6] update docs

* [Swift6] update docs

* Use multiline comments for examples in csharp generator (#19079)

* multi

* gen

* Uncomment File::deleteOnExit (#19624)

* [Core/Rust Server] Check references in additionalProperties correctly when checking freeForm status (#19605)

* Check references in additionalProperties correctly

Handle references in additionalProperties correctly when determining free-form status

* Update samples

* [Rust Server] Handle arrays in forms (#19625)

* [Rust Server] Handle arrays in forms correctly

* [Rust Server] Add tests

* Update samples

* [Swift6] fix CI

* [Swift6] fix CI

* [Swift6] fix CI

* [Swift6] fix CI

---------

Co-authored-by: Liri S <[email protected]>
Co-authored-by: Beppe Catanese <[email protected]>
Co-authored-by: Richard Whitehouse <[email protected]>
Co-authored-by: William Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants